[webkit-reviews] review granted: [Bug 175322] [WPE] Implement WebsiteDataStore::defaultApplicationCacheDirectory() and friends : [Attachment 317571] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 175322: [WPE] Implement
WebsiteDataStore::defaultApplicationCacheDirectory() and friends
https://bugs.webkit.org/show_bug.cgi?id=175322

Attachment 317571: Patch

https://bugs.webkit.org/attachment.cgi?id=317571&action=review




--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 317571
  --> https://bugs.webkit.org/attachment.cgi?id=317571
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317571&action=review

> Source/WebKit/UIProcess/API/APIWebsiteDataStore.cpp:91
> -#if !PLATFORM(COCOA) && !PLATFORM(GTK)
> +#if !PLATFORM(COCOA) && !PLATFORM(GTK) && !PLATFORM(WPE)
>  WebKit::WebsiteDataStore::Configuration
WebsiteDataStore::defaultDataStoreConfiguration()

This is now dead code then, I think we can just remove it.

> Source/WebKit/UIProcess/API/glib/APIWebsiteDataStoreGLib.cpp:32
> +# define PLATFORM_DIR_BASE "webkitgtk" G_DIR_SEPARATOR_S

Remove the space between # and define. I would call this BASE_DIRECTORY.

> Source/WebKit/UIProcess/API/glib/APIWebsiteDataStoreGLib.cpp:55
> +    return websiteDataDirectoryFileSystemRepresentation(PLATFORM_DIR_BASE
"databases" G_DIR_SEPARATOR_S "indexeddb");

This look weird now, I think it's better not to include G_DIR_SEPARATOR_S as
part of BASE_DIRECTORY macro