[webkit-reviews] review granted: [Bug 173297] [JSC] Crate JSSet constructor that accepts it's size as parameter : [Attachment 317538] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Caio Lima <ticaiolima at gmail.com>'s
request for review:
Bug 173297: [JSC] Crate JSSet constructor that accepts it's size as parameter
https://bugs.webkit.org/show_bug.cgi?id=173297

Attachment 317538: Patch

https://bugs.webkit.org/attachment.cgi?id=317538&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 317538
  --> https://bugs.webkit.org/attachment.cgi?id=317538
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317538&action=review

r=me

> Source/JavaScriptCore/runtime/HashMapImpl.h:303
> +    HashMapImpl(VM& vm, Structure* structure, uint32_t size)

Nit: Lets call this "expectedSize" or "sizeHint" to give a better intention of
what it is.