[webkit-reviews] review granted: [Bug 175116] [iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b, i, u inside a contenteditable div : [Attachment 317358] Adjust for review feedback.

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 175116: [iOS WK2] WKWebView schedules nonstop layout after pressing
cmb+b,i,u inside a contenteditable div
https://bugs.webkit.org/show_bug.cgi?id=175116

Attachment 317358: Adjust for review feedback.

https://bugs.webkit.org/attachment.cgi?id=317358&action=review




--- Comment #12 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 317358
  --> https://bugs.webkit.org/attachment.cgi?id=317358
Adjust for review feedback.

View in context: https://bugs.webkit.org/attachment.cgi?id=317358&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:906
> +	       if (auto* enclosingListElement =
enclosingList(selection.start().deprecatedNode())) {

Please use containerNode() instead.

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm:52
> +    [testHarness insertHTML:@"<span style='font-weight: 800'> third</span>"
andExpectEditorStateWith:@{ @"bold": @YES }];

Please add a test for font-weight: 400, 300, 700, etc...

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm:73
> +    [testHarness insertHTML:@"<span style='font-style: italic'>
third</span>" andExpectEditorStateWith:@{ @"italic": @YES }];

Please add a test case for oblique, which we treat as italic.

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm:96
> +    [testHarness insertHTML:@"<span style='text-decoration: underline'>
third</span>" andExpectEditorStateWith:@{ @"underline": @YES }];

Please add a test case when line-through and other text-decorations are also
specified.

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm:145
> +    [webView stringByEvaluatingJavaScript:@"document.body.style.direction =
'rtl'"];

Please adda  test case with dir="auto" where the directionality is determined
by a strongly RTL letter.