[webkit-reviews] review granted: [Bug 175301] Avoid a hash lookup in FilterInfo::remove() : [Attachment 317493] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 7 16:39:45 PDT 2017


Sam Weinig <sam at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 175301: Avoid a hash lookup in FilterInfo::remove()
https://bugs.webkit.org/show_bug.cgi?id=175301

Attachment 317493: Patch

https://bugs.webkit.org/attachment.cgi?id=317493&action=review




--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 317493
  --> https://bugs.webkit.org/attachment.cgi?id=317493
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317493&action=review

> Source/WebCore/rendering/RenderLayerFilterInfo.cpp:75
>      if (map().remove(&layer))
>	   layer.m_hasFilterInfo = false;

Do you need to check the return value still? Seems like it will always return
true now.


More information about the webkit-reviews mailing list