[webkit-reviews] review granted: [Bug 175280] Update sendBeacon() to rely on FetchBody instead of the whole FetchRequest : [Attachment 317454] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 175280: Update sendBeacon() to rely on FetchBody instead of the whole
FetchRequest
https://bugs.webkit.org/show_bug.cgi?id=175280

Attachment 317454: Patch

https://bugs.webkit.org/attachment.cgi?id=317454&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 317454
  --> https://bugs.webkit.org/attachment.cgi?id=317454
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317454&action=review

> Source/WebCore/ChangeLog:9
> +	   for data destruction is really the only thing we need at the moment.

data extraction?

> Source/WebCore/Modules/beacon/NavigatorBeacon.cpp:35
>  #include <runtime/JSCJSValue.h>

Do you still need that include?

> Source/WebCore/Modules/beacon/NavigatorBeacon.cpp:64
> +    options.redirect = FetchOptions::Redirect::Follow;

No need to set redirect to follow, this is the default and is not spelled out
in the spec explicitly.

> Source/WebCore/Modules/beacon/NavigatorBeacon.cpp:65
> +    options.cache = FetchOptions::Cache::NoCache;

I do not see that option set in the spec.
I forgot to ask why it was set in previous patches.