[webkit-reviews] review granted: [Bug 174919] Primitive auxiliaries and JSValue auxiliaries should have separate gigacages : [Attachment 317432] the patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 174919: Primitive auxiliaries and JSValue auxiliaries should have separate
gigacages
https://bugs.webkit.org/show_bug.cgi?id=174919

Attachment 317432: the patch

https://bugs.webkit.org/attachment.cgi?id=317432&action=review




--- Comment #10 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 317432
  --> https://bugs.webkit.org/attachment.cgi?id=317432
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317432&action=review

r=me.

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:11623
> +	   if (kind == Gigacage::Primitive) {
> +	       if (vm().primitiveGigacageEnabled().isStillValid())
> +		  
m_graph.watchpoints().addLazily(vm().primitiveGigacageEnabled());
> +	       else
> +		   return ptr;

Just to double check. We don't need this for the JSValue Gigacage because it
cannot be disabled?