[webkit-reviews] review canceled: [Bug 175210] [ESNext] Async iteration - Implement Async Generator - parser : [Attachment 317298] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 6 06:05:50 PDT 2017


GSkachkov <gskachkov at gmail.com> has canceled  review:
Bug 175210: [ESNext] Async iteration - Implement Async Generator - parser
https://bugs.webkit.org/show_bug.cgi?id=175210

Attachment 317298: Patch

https://bugs.webkit.org/attachment.cgi?id=317298&action=review




--- Comment #4 from GSkachkov <gskachkov at gmail.com> ---
Comment on attachment 317298
  --> https://bugs.webkit.org/attachment.cgi?id=317298
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317298&action=review

>> Source/JavaScriptCore/parser/ASTBuilder.h:440
>> +	    SourceParseMode sourceParseMode;
> 
> Let's rename this to `bodySourceParseMode` and set `bodySourceParseMode =
mode;` first.

Done

>> Source/JavaScriptCore/parser/ASTBuilder.h:451
>> +		sourceParseMode = mode;
> 
> Drop this.

Done


More information about the webkit-reviews mailing list