[webkit-reviews] review granted: [Bug 175083] REGRESSION (r219895-219897): Number of leaks on Open Source went from 9240 to 235983 and is now at 302372 : [Attachment 317355] the patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 175083: REGRESSION (r219895-219897): Number of leaks on Open Source went
from 9240 to 235983 and is now at 302372
https://bugs.webkit.org/show_bug.cgi?id=175083

Attachment 317355: the patch

https://bugs.webkit.org/attachment.cgi?id=317355&action=review




--- Comment #17 from Oliver Hunt <oliver at apple.com> ---
Comment on attachment 317355
  --> https://bugs.webkit.org/attachment.cgi?id=317355
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317355&action=review

r=me assuming perf is clean

> Source/WTF/ChangeLog:9
> +	   Adds a classic ReadWriteLock class. I wrote my own because I can
never remember if the pthread one is
> +	   guaranted to bias in favor of writers or not.

the best rationale :P

> Source/WTF/wtf/Condition.h:177
>      Atomic<bool> m_hasWaiters;

Any idea why this was protected in the first place? no matter, not relevant to
this patch, just curious