[webkit-reviews] review granted: [Bug 175205] [GTK][WPE] Turn on ENABLE_CANVAS_PATH by default : [Attachment 317276] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Brian Burg
<bburg at apple.com>'s request for review:
Bug 175205: [GTK][WPE] Turn on ENABLE_CANVAS_PATH by default
https://bugs.webkit.org/show_bug.cgi?id=175205

Attachment 317276: Patch

https://bugs.webkit.org/attachment.cgi?id=317276&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 317276
  --> https://bugs.webkit.org/attachment.cgi?id=317276
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317276&action=review

> Source/cmake/OptionsGTK.cmake:155
> -WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CANVAS_PATH PRIVATE OFF)
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CANVAS_PATH PRIVATE ON)

I have no idea why we have OFF here. Since the default is ON, we can probably
remove the line, but you are going to remove the build gflag eventually, so it
doesn't really matter.

> ChangeLog:3
> +	   [GTK][WPE] Turn on ENABLE_CANVAS_PATH by default

This doesn't change WPE