[webkit-reviews] review granted: [Bug 175201] [Cache API] Add Cache and CacheStorage IDL definitions : [Attachment 317320] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 175201: [Cache API] Add Cache and CacheStorage IDL definitions
https://bugs.webkit.org/show_bug.cgi?id=175201

Attachment 317320: Patch

https://bugs.webkit.org/attachment.cgi?id=317320&action=review




--- Comment #23 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 317320
  --> https://bugs.webkit.org/attachment.cgi?id=317320
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317320&action=review

> Source/WebCore/Modules/cache/Cache.h:52
> +    void match(RequestInfo&&, std::optional<CacheQueryOptions>&&,
Ref<DeferredPromise>&&);
> +    void matchAll(std::optional<RequestInfo>&&,
std::optional<CacheQueryOptions>&&, MatchAllPromise&&);
> +    void add(RequestInfo&&, DOMPromiseDeferred<void>&&);
> +
> +    void addAll(Vector<RequestInfo>&&, DOMPromiseDeferred<void>&&);
> +    void put(RequestInfo&&, Ref<FetchResponse>&&,
DOMPromiseDeferred<void>&&);
> +    void remove(RequestInfo&&, std::optional<CacheQueryOptions>&&,
DOMPromiseDeferred<IDLBoolean>&&);
> +    void keys(std::optional<RequestInfo>&&,
std::optional<CacheQueryOptions>&&, KeysPromise&&);

Why does one of these take a Ref<DefferedPromise>&& but the others take a
DOMPromiseDeferred<>&&?

In my (very recent) experience with IDLs and promise related code, I think the
code generator exclusively spat out Ref<DefferedPromise>&&