[webkit-reviews] review granted: [Bug 175225] Create a new JavaScript RegExp benchmark : [Attachment 317305] Patch

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 175225: Create a new JavaScript RegExp benchmark
https://bugs.webkit.org/show_bug.cgi?id=175225

Attachment 317305: Patch

https://bugs.webkit.org/attachment.cgi?id=317305&action=review




--- Comment #5 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 317305
  --> https://bugs.webkit.org/attachment.cgi?id=317305
Patch

Bugzilla seriously craps itself on this patch! Can't review inline...

Took a glance at what seems important, looks good overall. A few comments then
r=me

PerformanceTests/RexBench/about.html

"help compete and win". Always be winning.

“Flight Planner Unicode” should be in Unicode instead!

“ equivolents” typo

PerformanceTests/RexBench/basic_benchmark.js

Copyright is 2016 here (check others too…)

“I'd call this arguments but we're in strict mode.” :-)