[webkit-reviews] review granted: [Bug 175215] Have navigator.serviceWorker() actually return a ServiceWorkerContainer object : [Attachment 317303] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 4 15:36:39 PDT 2017
youenn fablet <youennf at gmail.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 175215: Have navigator.serviceWorker() actually return a
ServiceWorkerContainer object
https://bugs.webkit.org/show_bug.cgi?id=175215
Attachment 317303: Patch
https://bugs.webkit.org/attachment.cgi?id=317303&action=review
--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 317303
--> https://bugs.webkit.org/attachment.cgi?id=317303
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=317303&action=review
> Source/WebCore/workers/ServiceWorkerContainer.cpp:66
> + rejectLater(WTFMove(promise), "ready");
It seems unnecessary to reject later, why not doing it now?
More information about the webkit-reviews
mailing list