[webkit-reviews] review granted: [Bug 175192] [Beacon] Update sendBeacon to use the CachedResourceLoader : [Attachment 317283] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 4 15:19:02 PDT 2017


youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 175192: [Beacon] Update sendBeacon to use the CachedResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=175192

Attachment 317283: Patch

https://bugs.webkit.org/attachment.cgi?id=317283&action=review




--- Comment #24 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 317283
  --> https://bugs.webkit.org/attachment.cgi?id=317283
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317283&action=review

> Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:121
> +    case CachedResource::Beacon:

Shouldn't it be Seconds::infinity() since we might only care when the load is
finished in the future?


More information about the webkit-reviews mailing list