[webkit-reviews] review granted: [Bug 138593] Web Inspector: add source view for WebGL shader programs : [Attachment 317217] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 138593: Web Inspector: add source view for WebGL shader programs
https://bugs.webkit.org/show_bug.cgi?id=138593

Attachment 317217: Patch

https://bugs.webkit.org/attachment.cgi?id=317217&action=review




--- Comment #10 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 317217
  --> https://bugs.webkit.org/attachment.cgi?id=317217
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317217&action=review

r=me, with comments.

> Source/WebInspectorUI/ChangeLog:7
> +	   Reviewed by NOBODY (OOPS!).

Please add a short summary of the frontend bits.

> Source/WebCore/inspector/InspectorShaderProgram.cpp:69
> +	   return nullptr;

This should never happen so we should assert:

else {
    ASSERT_NOT_REACHED();
    return nullptr;
}

> Source/WebInspectorUI/UserInterface/Models/ShaderProgram.js:58
> +    }

Style: newline after.

> Source/WebInspectorUI/UserInterface/Views/ShaderProgramContentView.css:55
> +    padding: 0.1em 0.5em;

Nit: we usually use pixels for margin/padding. Our layout doesn't adapt to font
size, and ems are convenient but more difficult to reason about.

> Source/WebInspectorUI/UserInterface/Views/ShaderProgramContentView.css:61
> +    top: 1.5em;

See above.

> Source/WebInspectorUI/UserInterface/Views/ShaderProgramContentView.js:48
> +

Nit: remove space.

> Source/WebInspectorUI/UserInterface/Views/ShaderProgramContentView.js:51
> +		   break;

Nit: space after.

> Source/WebInspectorUI/UserInterface/Views/ShaderProgramContentView.js:54
> +

Ditto.

> Source/WebInspectorUI/UserInterface/Views/ShaderProgramContentView.js:66
> +

Remove space.

> Source/WebInspectorUI/UserInterface/Views/ShaderProgramContentView.js:93
> +	   super.hidden();

In general calls to super should always be first, unless there is good reason.

> Source/WebInspectorUI/UserInterface/Views/ShaderProgramContentView.js:101
> +	   super.closed();

Ditto.

> Source/WebInspectorUI/UserInterface/Views/ShaderProgramContentView.js:124
> +    get supportsSearch()

Inline.

> LayoutTests/inspector/canvas/requestShaderSource.html:61
> +    // ------

Remove comment.