[webkit-reviews] review granted: [Bug 174618] WebDriver: properly handle capabilities and process firstMatch too : [Attachment 317108] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 174618: WebDriver: properly handle capabilities and process firstMatch too
https://bugs.webkit.org/show_bug.cgi?id=174618

Attachment 317108: Patch

https://bugs.webkit.org/attachment.cgi?id=317108&action=review




--- Comment #10 from Brian Burg <bburg at apple.com> ---
Comment on attachment 317108
  --> https://bugs.webkit.org/attachment.cgi?id=317108
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317108&action=review

r=me

Please fix the capability parsing vs matching so that unimplemented ones are
recognized but not matchable.

> Source/WebDriver/WebDriverService.cpp:451
> +    if (!capabilitiesObject->getValue(ASCIILiteral("firstMatch"),
firstMatchCapabilitiesValue)) {

Referencing steps in the spec would help here, as the names here are quite
verbose yet not clear what the logic is.

> Source/WebDriver/WebDriverService.cpp:481
> +	      
completionHandler(CommandResult::fail(CommandResult::ErrorCode::SessionNotCreat
ed, String("Invalid capabilities")));

The error message could be better. This should only fail if a capability is in
both firstMatch and alwaysMatch.