[webkit-reviews] review granted: [Bug 175016] getClientRects doesn't work with list box option elements : [Attachment 317218] Updated patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 175016: getClientRects doesn't work with list box option elements
https://bugs.webkit.org/show_bug.cgi?id=175016

Attachment 317218: Updated patch

https://bugs.webkit.org/attachment.cgi?id=317218&action=review




--- Comment #24 from Darin Adler <darin at apple.com> ---
Comment on attachment 317218
  --> https://bugs.webkit.org/attachment.cgi?id=317218
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317218&action=review

> Source/WebCore/dom/Element.cpp:1166
> +    if (!selectElement->renderer() ||
!is<RenderListBox>(selectElement->renderer()))
> +	   return std::nullopt;

I think we still need to null-check selectElement here, since
ownerSelectElement can return nullptr.