[webkit-reviews] review granted: [Bug 175157] Dashboard bubbles sometimes show failure count instead of crash count : [Attachment 317163] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 4 09:35:14 PDT 2017


Alexey Proskuryakov <ap at webkit.org> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 175157: Dashboard bubbles sometimes show failure count instead of crash
count
https://bugs.webkit.org/show_bug.cgi?id=175157

Attachment 317163: Proposed patch

https://bugs.webkit.org/attachment.cgi?id=317163&action=review




--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 317163
  --> https://bugs.webkit.org/attachment.cgi?id=317163
Proposed patch

I think it's worth adding a comment explaining which two cases we support here,
especially given that there is no regression test.


More information about the webkit-reviews mailing list