[webkit-reviews] review granted: [Bug 175129] [EME] Push CDMFactory into the platform layer : [Attachment 317122] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 175129: [EME] Push CDMFactory into the platform layer
https://bugs.webkit.org/show_bug.cgi?id=175129

Attachment 317122: Patch

https://bugs.webkit.org/attachment.cgi?id=317122&action=review




--- Comment #3 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 317122
  --> https://bugs.webkit.org/attachment.cgi?id=317122
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317122&action=review

> Source/WebCore/platform/GStreamer.cmake:142
> +	   platform/encryptedmedia/gstreamer/CDMFactoryGStreamer.cpp

It looks like this file should go under platform/graphics/gstreamer/eme/

> Source/WebCore/platform/encryptedmedia/CDMFactory.cpp:2
> + * Copyright (C) 2016 Apple Inc. All rights reserved.

It looks like Igalia can have some credit here.

> Source/WebCore/platform/encryptedmedia/CDMFactory.h:2
> + * Copyright (C) 2016 Apple Inc. All rights reserved.

Ditto

> Source/WebCore/platform/encryptedmedia/CDMFactory.h:49
> +    // CDMFactory objectes is queried for the first time.

typo