[webkit-reviews] review granted: [Bug 175173] [Cleanup] Remove ScriptGlobalObject : [Attachment 317203] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 175173: [Cleanup] Remove ScriptGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=175173

Attachment 317203: Patch

https://bugs.webkit.org/attachment.cgi?id=317203&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 317203
  --> https://bugs.webkit.org/attachment.cgi?id=317203
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317203&action=review

> Source/WebCore/inspector/InspectorFrontendHost.cpp:388
> +    ASSERT(value && value.isObject());

Normally we would do this as two separate assertions so if one fails we know
which one.

> Source/WebCore/inspector/InspectorFrontendHost.cpp:389
> +    auto* frontendApiObject = asObject(value);

Strange capitalization of API here.