[webkit-reviews] review granted: [Bug 175139] Network cache should be usable as non-singleton : [Attachment 317168] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 3 16:07:47 PDT 2017


Sam Weinig <sam at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 175139: Network cache should be usable as non-singleton
https://bugs.webkit.org/show_bug.cgi?id=175139

Attachment 317168: patch

https://bugs.webkit.org/attachment.cgi?id=317168&action=review




--- Comment #5 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 317168
  --> https://bugs.webkit.org/attachment.cgi?id=317168
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317168&action=review

r=me when it all builds

> Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:121
> +	       NetworkCache::Cache::open(m_diskCacheDirectory, cacheOptions);

This feels too mysterious.  While I think you should store the Cache ref here,
maybe for now just a comment explaining what's happening.

> Source/WebKit/NetworkProcess/soup/NetworkProcessSoup.cpp:124
> +    NetworkCache::Cache::open(m_diskCacheDirectory, cacheOptions);

This feels too mysterious.  While I think you should store the Cache ref here,
maybe for now just a comment explaining what's happening.


More information about the webkit-reviews mailing list