[webkit-reviews] review denied: [Bug 174477] Create Individual EWS Pages : [Attachment 317149] status bubble link to individual EWS page.

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has denied obinna obike
<oobike at apple.com>'s request for review:
Bug 174477: Create Individual EWS Pages
https://bugs.webkit.org/show_bug.cgi?id=174477

Attachment 317149: status bubble link to individual EWS page.

https://bugs.webkit.org/attachment.cgi?id=317149&action=review




--- Comment #6 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 317149
  --> https://bugs.webkit.org/attachment.cgi?id=317149
status bubble link to individual EWS page.

View in context: https://bugs.webkit.org/attachment.cgi?id=317149&action=review

> Tools/ChangeLog:9
> +	   to go directly to the Individual EWS page.I also added made changes
to the code so that if the number

"added made changes" ?

> Tools/ChangeLog:10
> +	   of items in the queue is 0 then have a message that says waiting in
the queue processing hasnt started.

hasnt => hasn't.
0 => zero

> Tools/ChangeLog:11
> +	   I also added a link to the list of all of the EWS queues at the
bottom if there is no or one EWS on the page.

"if there is no or one EWS on the page"? Wouldn't that link be always there?

> Tools/ChangeLog:15
> +	   * QueueStatusServer/handlers/statusbubble.py:

Please add a small description of each change here as well.

> Tools/QueueStatusServer/handlers/patch.py:52
> +		       queue_status[status.queue_name] = per_queue_statuses

Did you see my previous comment: "As I requested couple of times in-person,
please avoid this code duplication. It's a simple if else, you should be able
to avoid the duplication."