[webkit-reviews] review granted: [Bug 175152] Improve WebKitLegacy video fullscreen animation begin and end rects. : [Attachment 317146] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 175152: Improve WebKitLegacy video fullscreen animation begin and end
rects.
https://bugs.webkit.org/show_bug.cgi?id=175152

Attachment 317146: Patch

https://bugs.webkit.org/attachment.cgi?id=317146&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 317146
  --> https://bugs.webkit.org/attachment.cgi?id=317146
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317146&action=review

> Source/WebCore/platform/mac/WebVideoFullscreenController.mm:236
> +static NSRect frameExpandedToRatioOfFrame(NSRect frameToExpand, NSRect
frame)

Nit: NSRect&

> Source/WebCore/platform/mac/WebVideoFullscreenController.mm:284
>      NSRect frame = [self videoElementRect];
>      NSRect endFrame = [screen frame];
> -    constrainFrameToRatioOfFrame(&endFrame, &frame);
> +    frame = frameExpandedToRatioOfFrame(frame, endFrame);

Nit: this would be slightly cleaner as something like

NSRect frame = frameExpandedToRatioOfFrame([self videoElementRect], endFrame);