[webkit-reviews] review granted: [Bug 175141] The allocator used to allocate memory for MarkedBlocks and LargeAllocations should not be the Subspace itself : [Attachment 317139] the patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 175141: The allocator used to allocate memory for MarkedBlocks and
LargeAllocations should not be the Subspace itself
https://bugs.webkit.org/show_bug.cgi?id=175141

Attachment 317139: the patch

https://bugs.webkit.org/attachment.cgi?id=317139&action=review




--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 317139
  --> https://bugs.webkit.org/attachment.cgi?id=317139
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317139&action=review

r=me with suggestions.

> Source/JavaScriptCore/heap/MarkedBlock.cpp:337
> +    RELEASE_ASSERT(m_allocator->subspace()->alignedMemoryAllocator() ==
m_alignedMemoryAllocator);

just use subspace() instead of m_allocator->subspace().

> Source/JavaScriptCore/heap/MarkedBlock.cpp:400
> +Subspace* MarkedBlock::Handle::subspace() const
> +{
> +    return allocator()->subspace();
> +}

Is there any reason this should not be an inline function?