[webkit-reviews] review granted: [Bug 175140] [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests. : [Attachment 317131] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Carlos Alberto Lopez Perez
<clopez at igalia.com>'s request for review:
Bug 175140: [GTK][WKE] Pass the --memory-limited option on the GTK and WPE
buildbots for the JSC tests.
https://bugs.webkit.org/show_bug.cgi?id=175140

Attachment 317131: Patch

https://bugs.webkit.org/attachment.cgi?id=317131&action=review




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 317131
  --> https://bugs.webkit.org/attachment.cgi?id=317131
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317131&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:338
> +	   # Linux bots have problems with JSC tests that try to use large
amounts of memory.

It would help to have a link to more information right here. It's of course
possible to get back to the bug using svn blame, but having the link in the
comment will save some time in the future.

The questions people will be asking are "Can I remove this now? What should I
test to confirm whether I can?"