[webkit-reviews] review requested: [Bug 175146] Add tests for NeverDestroyed : [Attachment 317137] [PATCH] Proposed Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 3 12:05:55 PDT 2017
Joseph Pecoraro <joepeck at webkit.org> has asked for review:
Bug 175146: Add tests for NeverDestroyed
https://bugs.webkit.org/show_bug.cgi?id=175146
Attachment 317137: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=317137&action=review
--- Comment #1 from Joseph Pecoraro <joepeck at webkit.org> ---
Created attachment 317137
--> https://bugs.webkit.org/attachment.cgi?id=317137&action=review
[PATCH] Proposed Fix
Is this what you guys were thinking? Any other specific tests you want me to
add?
I considered a test of NeverDestroyed with a RefCounted objects (these cases
trigger relaxAdoptionRequirement) but there are cases of this in other
TestWebKitAPI tests and it seems this would be about assertions.
More information about the webkit-reviews
mailing list