[webkit-reviews] review granted: [Bug 175108] Web Inspector: add button to open Inspector^2 : [Attachment 317064] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 3 10:40:51 PDT 2017


Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 175108: Web Inspector: add button to open Inspector^2
https://bugs.webkit.org/show_bug.cgi?id=175108

Attachment 317064: Patch

https://bugs.webkit.org/attachment.cgi?id=317064&action=review




--- Comment #3 from Brian Burg <bburg at apple.com> ---
Comment on attachment 317064
  --> https://bugs.webkit.org/attachment.cgi?id=317064
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317064&action=review

r=me

> Source/WebCore/inspector/InspectorFrontendHost.cpp:421
> +void InspectorFrontendHost::inspectInspector()

Did you test this in the remote inspection case? I am pretty sure it should
Just Work but that doesn't mean a whole lot.


More information about the webkit-reviews mailing list