[webkit-reviews] review granted: [Bug 175069] Improve our support for referrer policies : [Attachment 317087] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 175069: Improve our support for referrer policies
https://bugs.webkit.org/show_bug.cgi?id=175069

Attachment 317087: Patch

https://bugs.webkit.org/attachment.cgi?id=317087&action=review




--- Comment #17 from Darin Adler <darin at apple.com> ---
Comment on attachment 317087
  --> https://bugs.webkit.org/attachment.cgi?id=317087
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317087&action=review

> Source/WebCore/dom/Document.cpp:3381
> +    // "never" / "default" / "always" are legacy keywords that we will
support. They were defined in:
> +    //
https://www.w3.org/TR/2014/WD-referrer-policy-20140807/#referrer-policy-deliver
y-meta

We plan to support them forever?

> Source/WebCore/page/SecurityPolicy.cpp:92
> +	   RELEASE_ASSERT_NOT_REACHED();

Does this really need to be RELEASE_ASSERT_NOT_REACHED? What’s the best
guideline for this sort of thing? Should we get rid of ASSERT_NOT_REACHED? Why
not just fall into NoReferrer after ASSERT_NOT_REACHED in this case in
production builds? I think of RELEASE_ASSERT as something we use only in
unusual circumstances.