[webkit-reviews] review granted: [Bug 175128] [EME] CDM constructor assigns CDMPrivate member multiple times : [Attachment 317114] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 175128: [EME] CDM constructor assigns CDMPrivate member multiple times
https://bugs.webkit.org/show_bug.cgi?id=175128

Attachment 317114: Patch

https://bugs.webkit.org/attachment.cgi?id=317114&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 317114
  --> https://bugs.webkit.org/attachment.cgi?id=317114
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317114&action=review

> Source/WebCore/ChangeLog:13
> +	   In the CDM class constructor, create the CDMPrivate object for
> +	   the first key system we're able to determine as being supported,
> +	   stopping iteration of the registered CDM factories at that point.
> +	   This is done in a dedicated loop inside the constructor body,
> +	   meaning the helper createCDMPrivateForKeySystem() function can
> +	   be removed.

I find syntax of the first sentence a bit complex to understand.