[webkit-reviews] review granted: [Bug 175124] [Linux][WTF] Use one global semaphore to notify thread suspend and resume completion : [Attachment 317109] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 175124: [Linux][WTF] Use one global semaphore to notify thread suspend and
resume completion
https://bugs.webkit.org/show_bug.cgi?id=175124

Attachment 317109: Patch

https://bugs.webkit.org/attachment.cgi?id=317109&action=review




--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 317109
  --> https://bugs.webkit.org/attachment.cgi?id=317109
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317109&action=review

> Source/WTF/wtf/ThreadingPthreads.cpp:89
> +    Semaphore(unsigned initialValue)

explicit?

> Source/WTF/wtf/ThreadingPthreads.cpp:92
> +	   int sharedBetweenProcesses = 0;
> +	   sem_init(&m_platformSemaphore, sharedBetweenProcesses,
initialValue);

Do we really need a local variable? or is it to document what that 0 means?

> Source/WTF/wtf/ThreadingPthreads.cpp:202
> +    globalSemaphoreForSuspendResume.construct(0);

This is the only place it's constructed and we always pass 0 as initial value,
right?