[webkit-reviews] review granted: [Bug 159510] [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing. : [Attachment 316979] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 159510: [Win] The test
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgra
de.https.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=159510

Attachment 316979: Patch

https://bugs.webkit.org/attachment.cgi?id=316979&action=review




--- Comment #7 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 316979
  --> https://bugs.webkit.org/attachment.cgi?id=316979
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316979&action=review

> Tools/DumpRenderTree/win/DumpRenderTree.cpp:1214
> +    request->setAllowsAnyHTTPSCertificate();

OK. Although it is unlikely that DumpRenderTree would be used to load an
arbitrary URL (and would be an error if run-webkit-test ever invoked with a
non-file, non-localhost URL) it would be good practice to take a similar
approach as in Mac DumpRenderTree/WebKitTestRunner and only allow any HTTPS
certificate for localhost and 127.0.0.1.