[webkit-reviews] review granted: [Bug 175063] Use MPAVRoutingController instead of deprecated versions. : [Attachment 316987] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 175063: Use MPAVRoutingController instead of deprecated versions.
https://bugs.webkit.org/show_bug.cgi?id=175063

Attachment 316987: Patch

https://bugs.webkit.org/attachment.cgi?id=316987&action=review




--- Comment #13 from Tim Horton <thorton at apple.com> ---
Comment on attachment 316987
  --> https://bugs.webkit.org/attachment.cgi?id=316987
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316987&action=review

> Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm:45
> +    WKContentView *_view; // Weak reference.

Looks like a raw pointer, not weak, to me!

> Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm:71
> +    __block RetainPtr<MPAVRoutingController> routingController =
adoptNS([allocMPAVRoutingControllerInstance() initWithName:@"WebKit2 - HTML
media element showing AirPlay route picker"]);

Maybe drop the 2 :)