[webkit-reviews] review granted: [Bug 175055] ResourceLoadStatisticsClassifierCocoa::singletonPredictionModel() should check the return value of storagePath() before attempting to load : [Attachment 316906] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 175055: ResourceLoadStatisticsClassifierCocoa::singletonPredictionModel()
should check the return value of storagePath() before attempting to load
https://bugs.webkit.org/show_bug.cgi?id=175055

Attachment 316906: Patch

https://bugs.webkit.org/attachment.cgi?id=316906&action=review




--- Comment #5 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 316906
  --> https://bugs.webkit.org/attachment.cgi?id=316906
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316906&action=review

r=me since this resolves a thread-safety issue when creating
corePredictionModel (since thread-safe C++ statics are disabled in WebKit), but
I'm not sure it will resolve all potential causes of this crash.

Need to check if the CorePrediction API being used is also thread-safe when
using the same model on more than one thread at the same time.

>
Source/WebKit/Platform/classifier/cocoa/ResourceLoadStatisticsClassifierCocoa.c
pp:111
> +	   if (path.isEmpty())
> +	       return;

You should add some WTFLogAlways() logging output here, too, if it's unexpected
that this path will ever be empty.