[webkit-reviews] review granted: [Bug 175010] Use LazyNeverDestroyed instead of DEFINE_GLOBAL for QualifiedName : [Attachment 316933] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 175010: Use LazyNeverDestroyed instead of DEFINE_GLOBAL for QualifiedName
https://bugs.webkit.org/show_bug.cgi?id=175010

Attachment 316933: Patch

https://bugs.webkit.org/attachment.cgi?id=316933&action=review




--- Comment #11 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 316933
  --> https://bugs.webkit.org/attachment.cgi?id=316933
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316933&action=review

> Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp:431
>      AtomicString::init();
> +    WebCore::QualifiedName::init();

This could be a bad binary compatibility issue to add a new requirement to call
QualifiedName::init where we didn't have to before.