[webkit-reviews] review granted: [Bug 174803] Web Automation: files selected for upload should be checked against values of the 'accept' attribute : [Attachment 316914] Proposed Fix

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Brian Burg
<bburg at apple.com>'s request for review:
Bug 174803: Web Automation: files selected for upload should be checked against
values of the 'accept' attribute
https://bugs.webkit.org/show_bug.cgi?id=174803

Attachment 316914: Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=316914&action=review




--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 316914
  --> https://bugs.webkit.org/attachment.cgi?id=316914
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=316914&action=review

> Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:559
> +	   if (!allowedMIMETypes.size())
> +	       continue;

Nit: I usually prefer isEmpty()

> Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:579
> +	       filesAreValid = false;
> +	       break;

I think this would be easier if we moved this loop into a function, then you
could just return false instead of filesAreValid = false + break;