[webkit-reviews] review granted: [Bug 175064] CFString leak dragging an image - allocation under PlatformPasteboard::writeObjectRepresentations : [Attachment 316931] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 175064: CFString leak dragging an image - allocation under
PlatformPasteboard::writeObjectRepresentations
https://bugs.webkit.org/show_bug.cgi?id=175064

Attachment 316931: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=316931&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 316931
  --> https://bugs.webkit.org/attachment.cgi?id=316931
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=316931&action=review

> Source/WebCore/platform/ios/PlatformPasteboardIOS.mm:296
>	   auto utiOrMIMEType =
pasteboardImage.resourceMIMEType.createCFString();

This is one of those times where I really don't like this auto

> Source/WebCore/platform/ios/WebItemProviderPasteboard.mm:121
> +    [_suggestedName release];

Alternatively, we could stop with the autosynthesis and back this with a
RetainPtr.