[webkit-reviews] review granted: [Bug 174727] Bmalloc and GC should put auxiliaries (butterflies, typed array backing stores) in a gigacage (separate multi-GB VM region) : [Attachment 316887] with more fixes

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 174727: Bmalloc and GC should put auxiliaries (butterflies, typed array
backing stores) in a gigacage (separate multi-GB VM region)
https://bugs.webkit.org/show_bug.cgi?id=174727

Attachment 316887: with more fixes

https://bugs.webkit.org/attachment.cgi?id=316887&action=review




--- Comment #103 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 316887
  --> https://bugs.webkit.org/attachment.cgi?id=316887
with more fixes

View in context: https://bugs.webkit.org/attachment.cgi?id=316887&action=review

r=me with remaining issues resolved.

> Source/JavaScriptCore/dfg/DFGFixedButterflyAccessUncagingPhase.cpp:75
> +			   if (!readsOverlap(m_graph, node, Heap))

We discussed offline that this should be accessOverlaps instead.