[webkit-reviews] review granted: [Bug 175009] REGRESSION (r217197): New Yorker website hangs for a long time on load, lots of blank tiles : [Attachment 316831] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted  review:
Bug 175009: REGRESSION (r217197): New Yorker website hangs for a long time on
load, lots of blank tiles
https://bugs.webkit.org/show_bug.cgi?id=175009

Attachment 316831: Patch

https://bugs.webkit.org/attachment.cgi?id=316831&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 316831
  --> https://bugs.webkit.org/attachment.cgi?id=316831
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316831&action=review

> Source/WebCore/ChangeLog:9
> +	   This patch ensures that we report the desktop, non-frame-flattened
frame size for media queries.

"for media queries in subframes"

> Source/WebCore/ChangeLog:11
> +	   Some websites don't expect the iframes to be expanded and their
media query callbacks code
> +	   result in never ending layouts. 

I think you should say a little more here about what the site was doing (MQ
listener changing content, triggering resize across the MQ boundary).

> Source/WebCore/page/FrameView.cpp:-1387
> -

i want this one

> Source/WebCore/page/FrameView.cpp:5415
> +    if (isFrameFlatteningValidForThisFrame() &&
!m_frameFlatteningViewSizeForMediaQuery)
> +	   m_frameFlatteningViewSizeForMediaQuery = ScrollView::layoutSize();

Maybe do this somewhere you know you are already in a flattened frame layout.

> LayoutTests/ChangeLog:11
> +	   * fast/frames/flattening/media-query-growing-content-expected.txt:
Added.
> +	   * fast/frames/flattening/media-query-growing-content.html: Added.
> +	   *
fast/frames/flattening/resources/media-query-min-height-with-flattening.html:
Added.

Please also test aspect-ratio and orientation media queries.