[webkit-reviews] review granted: [Bug 174420] [WebCrypto] Add PKCS#8 import test that covers `parameters` and `publicKey` values in ECPrivateKey : [Attachment 316843] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Zan Dobersek <zan at falconsigh.net>'s
request for review:
Bug 174420: [WebCrypto] Add PKCS#8 import test that covers `parameters` and
`publicKey` values in ECPrivateKey
https://bugs.webkit.org/show_bug.cgi?id=174420

Attachment 316843: Patch

https://bugs.webkit.org/attachment.cgi?id=316843&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 316843
  --> https://bugs.webkit.org/attachment.cgi?id=316843
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316843&action=review

>
LayoutTests/crypto/subtle/ecdh-import-pkcs8-key-p256-validate-ecprivatekey-para
meters-publickey.html:61
> +<script src="../../resources/js-test-post.js"></script>

This is old style. For new tests we should just use js-test.js at the start,
not both pre/post.

>
LayoutTests/crypto/subtle/ecdh-import-pkcs8-key-p384-validate-ecprivatekey-para
meters-publickey.html:61
> +<script src="../../resources/js-test-post.js"></script>

Ditto.

>
LayoutTests/crypto/subtle/ecdsa-import-pkcs8-key-p256-validate-ecprivatekey-par
ameters-publickey.html:61
> +<script src="../../resources/js-test-post.js"></script>

Ditto.

>
LayoutTests/crypto/subtle/ecdsa-import-pkcs8-key-p384-validate-ecprivatekey-par
ameters-publickey.html:61
> +<script src="../../resources/js-test-post.js"></script>

Ditto.