[webkit-reviews] review granted: [Bug 171170] [ATK] ARIA treegrid role should be exposed as ATK_ROLE_TREE_TABLE; not ATK_ROLE_TABLE : [Attachment 308674] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 30 09:28:00 PDT 2017


chris fleizach <cfleizach at apple.com> has granted Joanmarie Diggs (irc: joanie)
<jdiggs at igalia.com>'s request for review:
Bug 171170: [ATK] ARIA treegrid role should be exposed as ATK_ROLE_TREE_TABLE;
not ATK_ROLE_TABLE
https://bugs.webkit.org/show_bug.cgi?id=171170

Attachment 308674: Patch

https://bugs.webkit.org/attachment.cgi?id=308674&action=review




--- Comment #5 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 308674
  --> https://bugs.webkit.org/attachment.cgi?id=308674
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308674&action=review

>> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:581
>> +	    return object.isTable();
> 
> Chris: Isn't the above the change you're asking me to make in your review?
Otherwise, I'm suffering from grepfail.

ah sorry!


More information about the webkit-reviews mailing list