[webkit-reviews] review denied: [Bug 171265] test262: Completion values for control flow do not match the spec : [Attachment 308678] [PATCH] Proposed Fix v2

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has denied Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 171265: test262: Completion values for control flow do not match the spec
https://bugs.webkit.org/show_bug.cgi?id=171265

Attachment 308678: [PATCH] Proposed Fix v2

https://bugs.webkit.org/attachment.cgi?id=308678&action=review




--- Comment #24 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 308678
  --> https://bugs.webkit.org/attachment.cgi?id=308678
[PATCH] Proposed Fix v2

View in context: https://bugs.webkit.org/attachment.cgi?id=308678&action=review

> JSTests/stress/completion-value.js:190
> +shouldBe(eval(`99; do { try { break; } catch (e) { -1 } } while (false);`),
undefined);

A slight modification to this causes it to fail:

    shouldBe(eval(`99; do { try { break; } catch (e) { -1 } } while (false);`),
undefined); // pass
    shouldBe(eval(`99; do { -2; try { break; } catch (e) { -1 }; -3 } while
(false);`), undefined); // fails with -2

We would need the loads of undefined like we did with IfElse/With.