[webkit-reviews] review granted: [Bug 171439] Use PEP8 style guide for raising exceptions in webkitpy. : [Attachment 308559] Proposed path

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 171439: Use PEP8 style guide for raising exceptions in webkitpy.
https://bugs.webkit.org/show_bug.cgi?id=171439

Attachment 308559: Proposed path

https://bugs.webkit.org/attachment.cgi?id=308559&action=review




--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 308559
  --> https://bugs.webkit.org/attachment.cgi?id=308559
Proposed path

View in context: https://bugs.webkit.org/attachment.cgi?id=308559&action=review

> Tools/ChangeLog:9
> +	   "When raising an exception in Python 2, use raise
ValueError('message') 

Does check-webkit-style check for this? If not, we should teach it to check for
this style.

> Tools/Scripts/webkitpy/common/net/irc/ircbot.py:-38
> -	   raise NotImplementedError, "subclasses must implement"

We should also take this opportunity to switch to single quoted string
literals.

> Tools/Scripts/webkitpy/common/net/irc/ircbot.py:41
> +	   raise NotImplementedError("subclasses must implement")

Ditto.

> Tools/Scripts/webkitpy/common/net/irc/ircbot.py:44
> +	   raise NotImplementedError("subclasses must implement")

Ditto.

> Tools/Scripts/webkitpy/common/thread/messagepump.py:32
> +	   raise NotImplementedError("subclasses must implement")

Ditto.

> Tools/Scripts/webkitpy/common/thread/messagepump.py:35
> +	   raise NotImplementedError("subclasses must implement")

Ditto.

> Tools/Scripts/webkitpy/common/thread/messagepump.py:38
> +	   raise NotImplementedError("subclasses must implement")

Ditto.

> Tools/Scripts/webkitpy/tool/multicommandtool.py:133
> +	   raise NotImplementedError("subclasses must implement")

Ditto.

> Tools/Scripts/webkitpy/tool/multicommandtool.py:265
> +	   raise NotImplementedError("subclasses must implement")

Ditto.

> Tools/Scripts/webkitpy/tool/bot/queueengine.py:52
> +	   raise NotImplementedError("subclasses must implement")

Ditto.

> Tools/Scripts/webkitpy/tool/bot/queueengine.py:55
> +	   raise NotImplementedError("subclasses must implement")

Ditto.

> Tools/Scripts/webkitpy/tool/bot/queueengine.py:58
> +	   raise NotImplementedError("subclasses must implement")

Ditto.

> Tools/Scripts/webkitpy/tool/bot/queueengine.py:61
> +	   raise NotImplementedError("subclasses must implement")

Ditto.

> Tools/Scripts/webkitpy/tool/bot/queueengine.py:64
> +	   raise NotImplementedError("subclasses must implement")

Ditto.

> Tools/Scripts/webkitpy/tool/bot/queueengine.py:67
> +	   raise NotImplementedError("subclasses must implement")

Ditto.

> Tools/Scripts/webkitpy/tool/bot/queueengine.py:70
> +	   raise NotImplementedError("subclasses must implement")

Ditto.

> Tools/Scripts/webkitpy/tool/commands/queues.py:121
> +	   raise NotImplementedError("subclasses must implement")

Ditto.

> Tools/Scripts/webkitpy/tool/commands/queues.py:141
> +	   raise NotImplementedError("subclasses must implement")

Ditto.

> Tools/Scripts/webkitpy/tool/commands/queues.py:144
> +	   raise NotImplementedError("subclasses must implement")

Ditto.

> Tools/Scripts/webkitpy/tool/commands/queues.py:147
> +	   raise NotImplementedError("subclasses must implement")

Ditto.

> Tools/Scripts/webkitpy/tool/commands/stepsequence.py:43
> +	   raise NotImplementedError("subclasses must implement")

Ditto.

> Tools/Scripts/webkitpy/tool/commands/stepsequence.py:47
> +	   raise NotImplementedError("subclasses must implement")

Ditto.

> Tools/Scripts/webkitpy/tool/steps/abstractstep.py:79
> +	   raise NotImplementedError("subclasses must implement")

Ditto.