[webkit-reviews] review granted: [Bug 171474] [JSC] LabelScopePtr is not necessary : [Attachment 308664] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 171474: [JSC] LabelScopePtr is not necessary
https://bugs.webkit.org/show_bug.cgi?id=171474

Attachment 308664: Patch

https://bugs.webkit.org/attachment.cgi?id=308664&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 308664
  --> https://bugs.webkit.org/attachment.cgi?id=308664
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308664&action=review

r=me

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:66
> +static inline void reclaim(T& segmentedVector)

I would call this "shrinkToFit" like Vector<T>::shrinkToFit.

>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:72
>> +	// loop condition is a workaround.
> 
> Old code says so. But I'm not sure the above claim is still valid.

I think it's good to remove workarounds like this over time. Maybe we should
remove this.