[webkit-reviews] review granted: [Bug 171456] Deep nesting is leading to ReferenceError for hoisted function : [Attachment 308663] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Apr 29 06:03:52 PDT 2017
Yusuke Suzuki <utatane.tea at gmail.com> has granted GSkachkov
<gskachkov at gmail.com>'s request for review:
Bug 171456: Deep nesting is leading to ReferenceError for hoisted function
https://bugs.webkit.org/show_bug.cgi?id=171456
Attachment 308663: Patch
https://bugs.webkit.org/attachment.cgi?id=308663&action=review
--- Comment #4 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 308663
--> https://bugs.webkit.org/attachment.cgi?id=308663
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=308663&action=review
Nice! r=me with comment.
> Source/JavaScriptCore/parser/Parser.h:228
> {
Listing all the members are not a scalable way. Can we just do `Scope(Scope&&)
= default;` here?
More information about the webkit-reviews
mailing list