[webkit-reviews] review granted: [Bug 171180] AX: ARIA "region" role which lacks an accessible name should not be treated as a landmark : [Attachment 308612] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Joanmarie Diggs (irc: joanie)
<jdiggs at igalia.com>'s request for review:
Bug 171180: AX: ARIA "region" role which lacks an accessible name should not be
treated as a landmark
https://bugs.webkit.org/show_bug.cgi?id=171180

Attachment 308612: Patch

https://bugs.webkit.org/attachment.cgi?id=308612&action=review




--- Comment #5 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 308612
  --> https://bugs.webkit.org/attachment.cgi?id=308612
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308612&action=review

>>> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:2128
>>> +	 if (role == LandmarkRegionRole && !hasAttribute(aria_labelAttr) &&
!hasAttribute(aria_labelledbyAttr))
>> 
>> do we think this is exhaustive !hasAttribute(aria_labelAttr) &&
!hasAttribute(aria_labelledbyAttr)
>> or are there are ways we should verify it has a label?
> 
> It's admittedly not exhaustive. How exhaustive do you think we should be? Add
alt and title? Or something else?

I don't know. I just wanted to bring it up to make sure we considered the other
cases. 
I don't want to encourage devs to keep using title attribute though so maybe
this is good enough