[webkit-reviews] review granted: [Bug 171453] On-screen panel for candidate bar is in the wrong place when the caret is at the start of a paragraph : [Attachment 308613] Patch+test

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 171453: On-screen panel for candidate bar is in the wrong place when the
caret is at the start of a paragraph
https://bugs.webkit.org/show_bug.cgi?id=171453

Attachment 308613: Patch+test

https://bugs.webkit.org/attachment.cgi?id=308613&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 308613
  --> https://bugs.webkit.org/attachment.cgi?id=308613
Patch+test

View in context: https://bugs.webkit.org/attachment.cgi?id=308613&action=review

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:250
> +    EXPECT_EQ(194, candidateRect.origin.y);

Will this change if the font changes? That might be annoying. Could use JS to
get the real number, or use Ahem, or ...