[webkit-reviews] review granted: [Bug 171412] Stop using legacy ClientRect / ClientRectList in Internals : [Attachment 308601] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 171412: Stop using legacy ClientRect / ClientRectList in Internals
https://bugs.webkit.org/show_bug.cgi?id=171412

Attachment 308601: Patch

https://bugs.webkit.org/attachment.cgi?id=308601&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 308601
  --> https://bugs.webkit.org/attachment.cgi?id=308601
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308601&action=review

> LayoutTests/ChangeLog:43
> +2017-04-28  Chris Dumez  <cdumez at apple.com>
> +
> +	   Stop using legacy ClientRect / ClientRectList in Internals
> +	   https://bugs.webkit.org/show_bug.cgi?id=171412
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Rebaseline existing tests as DOMRect has more properties than
ClientRect.
> +
> +	   * fast/visual-viewport/nonzoomed-rects-expected.txt:
> +	   * fast/visual-viewport/rtl-nonzoomed-rects-expected.txt:
> +	   * fast/visual-viewport/rtl-zoomed-rects-expected.txt:
> +	   * fast/visual-viewport/rubberbanding-viewport-rects-expected.txt:
> +	   *
fast/visual-viewport/rubberbanding-viewport-rects-extended-background-expected.
txt:
> +	   *
fast/visual-viewport/rubberbanding-viewport-rects-header-footer-expected.txt:
> +	   * fast/visual-viewport/zoomed-fixed-expected.txt:
> +	   * fast/visual-viewport/zoomed-fixed-header-and-footer-expected.txt:
> +	   * fast/visual-viewport/zoomed-rects-expected.txt:
> +	   * inspector/dom/hideHighlight-expected.txt:
> +	   * inspector/dom/highlightQuad-expected.txt:
> +	   * inspector/dom/highlightRect-expected.txt:

Double changelog