[webkit-reviews] review granted: [Bug 171453] On-screen panel for candidate bar is in the wrong place when the caret is at the start of a paragraph : [Attachment 308602] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 171453: On-screen panel for candidate bar is in the wrong place when the
caret is at the start of a paragraph
https://bugs.webkit.org/show_bug.cgi?id=171453

Attachment 308602: Patch

https://bugs.webkit.org/attachment.cgi?id=308602&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 308602
  --> https://bugs.webkit.org/attachment.cgi?id=308602
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308602&action=review

No test? :)

> Source/WebKit2/ChangeLog:13
> +	   is because Range::absoluteTextQuads() returns no quads in this case.
I think it 
> +	   might be correct that absoluteTextQuads() returns no quads in this
case, so this 

Should check with Zalan to see if he thinks this is actually correct or a
deeper bug.