[webkit-reviews] review granted: [Bug 171396] Add WebCore::protocolIsJavaScript(StringView) : [Attachment 308455] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 171396: Add WebCore::protocolIsJavaScript(StringView)
https://bugs.webkit.org/show_bug.cgi?id=171396

Attachment 308455: Patch

https://bugs.webkit.org/attachment.cgi?id=308455&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 308455
  --> https://bugs.webkit.org/attachment.cgi?id=308455
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308455&action=review

r=me
I think we should get rid of all instances of protocolIs that take Strings
instead of URLs.  They're probably a marginal performance benefit, but we
should really parse URLs rather than maintain a separate code path that looks
enough like the URLParser.

> Source/WebCore/platform/URL.h:315
> +bool protocolIsJavaScript(StringView url);

Did you want to use this somewhere?  This patch only changes URL.h and URL.cpp.