[webkit-reviews] review granted: [Bug 171393] Range.getClientRects() / getBoundingClientRect() should return DOMRect types : [Attachment 308530] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 28 14:14:36 PDT 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 171393: Range.getClientRects() / getBoundingClientRect() should return
DOMRect types
https://bugs.webkit.org/show_bug.cgi?id=171393

Attachment 308530: Patch

https://bugs.webkit.org/attachment.cgi?id=308530&action=review




--- Comment #8 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 308530
  --> https://bugs.webkit.org/attachment.cgi?id=308530
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308530&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:3325
>		83120C711C56F3FB001CB112 /* HTMLDataElement.h in Headers */ =
{isa = PBXBuildFile; fileRef = 834B86A71C56E83A00F3F0E3 /* HTMLDataElement.h
*/; };
> +		83149FF61EB38B3700089665 /* DOMRect.cpp in Sources */ = {isa =
PBXBuildFile; fileRef = 83149FF51EB38B1200089665 /* DOMRect.cpp */; };

Should probably run sort-Xcode-project-file


More information about the webkit-reviews mailing list