[webkit-reviews] review granted: [Bug 170548] Tweak window.open features argument tokenizer to match HTML standard and Edge : [Attachment 308404] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 170548: Tweak window.open features argument tokenizer to match HTML
standard and Edge
https://bugs.webkit.org/show_bug.cgi?id=170548

Attachment 308404: Patch

https://bugs.webkit.org/attachment.cgi?id=308404&action=review




--- Comment #40 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 308404
  --> https://bugs.webkit.org/attachment.cgi?id=308404
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308404&action=review

r=me

> Source/WebCore/page/WindowFeatures.cpp:51
> +    switch (mode) {
> +    case FeatureMode::Viewport:
> +	   return character == ' ' || character == '\t' || character == '\n' ||
character == '\r' || character == '=' || character == ',';
> +    case FeatureMode::Window:
> +	   break;
> +    }

I think this would be clearer as an if.